Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Base64 encoding/decoding with new EncoderDecoder #62

Merged
merged 5 commits into from
Jan 22, 2023
Merged

Implement Base64 encoding/decoding with new EncoderDecoder #62

merged 5 commits into from
Jan 22, 2023

Conversation

05nelsonm
Copy link
Owner

@05nelsonm 05nelsonm commented Jan 22, 2023 •
edited
Loading

Closes #42
Closes #26

This PR:

  • Implements encoding/decoding for all variants of Base64 (Default, UrlSafe) using the new EncoderDecoder
  • Maps the old encoding/decoding extension function bodies to use the new EncoderDecoder for Base64
  • Introduces a final Buffer implementation (FeedBuffer) that I am happy with

@05nelsonm 05nelsonm self-assigned this Jan 22, 2023
@05nelsonm 05nelsonm mentioned this pull request Jan 22, 2023
Closed
@05nelsonm 05nelsonm merged commit 54b7026 into master Jan 22, 2023
@05nelsonm 05nelsonm deleted the issue/42-base64-encoder-decoder branch January 22, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@05nelsonm 05nelsonm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate encoding-base64 to use encoding-core Fix base64 package path
1 participant
@05nelsonm