Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kotlin-components submodule #98

Merged
merged 11 commits into from
Mar 2, 2023
Merged

Remove kotlin-components submodule #98

merged 11 commits into from
Mar 2, 2023

Conversation

05nelsonm
Copy link
Owner

@05nelsonm 05nelsonm commented Mar 2, 2023 •
edited
Loading

Closes #96

This PR:

  • Removes all dependence on the kotlin-components submodule
  • Removes the Android sample
  • Adds documentation for the release process

@05nelsonm 05nelsonm self-assigned this Mar 2, 2023
@05nelsonm
Copy link
Owner Author

Enabling support for wasm will be handled in #97 as there are some configuration errors with testing when building.

05nelsonm
05nelsonm commented Mar 2, 2023
View reviewed changes
Copy link
Owner Author

@05nelsonm 05nelsonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@05nelsonm
Copy link
Owner Author

CI is still trying to hash kotlin-components/includeBuild/dependencies/src/main/kotlin/versions.kt

Need to hash gradle/libs.versions.toml instead.

@05nelsonm 05nelsonm merged commit e326e9c into master Mar 2, 2023
@05nelsonm 05nelsonm deleted the issue/96-remove-kotlin-components branch March 2, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@05nelsonm 05nelsonm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate away from kotlin-components submodule
1 participant
@05nelsonm