Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chdir #63

Merged
merged 15 commits into from
Feb 28, 2024
Merged

Add chdir #63

merged 15 commits into from
Feb 28, 2024

Conversation

05nelsonm
Copy link
Owner

Closes #15

@05nelsonm 05nelsonm self-assigned this Feb 28, 2024
05nelsonm
05nelsonm commented Feb 28, 2024
View reviewed changes
Copy link
Owner Author

@05nelsonm 05nelsonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@05nelsonm
Copy link
Owner Author

Yeah, posix_spawn and chdir is finicky.... especially with the darwin implementation.

https://github.com/05nelsonm/kmp-process/actions/runs/8077617801/job/22068267162?pr=63#step:8:756

Maybe macos should throw unsupported operation and fall back to using fork & exec?

@05nelsonm 05nelsonm merged commit 08a82ff into master Feb 28, 2024
8 checks passed
@05nelsonm 05nelsonm deleted the issue/15-chgdir branch February 28, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@05nelsonm 05nelsonm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Process.Builder.workingDirectory option
1 participant
@05nelsonm