-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to merge with official mod #71
base: master
Are you sure you want to change the base?
Conversation
@StanleySweet i need your eyes here too |
@StanleySweet |
Hey @7wells nice to be reading from you. Yes you can definitely report issues and make PRs here! That is the case for all the other mods on 0ADmods. :) |
@StanleySweet PS: |
Hey,
The community mod is officially maintained by Wildfire games
Those mods are not.
Initially there was a plan to migrate to a self hosted gitlab so developping the mod on Gitlab seemed smart. However Blender is migrating from Phabricator to Gitea and I decided to jump on that bandwagon instead since Gitlab community has a lot of missing features.
Anyway you should stop hijacking those conversations issues and contact me directly, after my break of course (check out the forums.
Best regards
Stan
…________________________________
De : 7wells ***@***.***>
Envoyé : lundi 24 octobre 2022 à 19:49
À : 0ADMods/millenniumad ***@***.***>
Cc : Stanislas Dolcini ***@***.***>; Mention ***@***.***>
Objet : Re: [0ADMods/millenniumad] Attempt to merge with official mod (PR #71)
@StanleySweet<https://github.com/StanleySweet>
Why is the Community mod at GitLab<https://gitlab.com/0ad/0ad-community-mod-a26>, whereas the other mods are here at GitHub? Is a transition taking place, or have I overseen something?
—
Reply to this email directly, view it on GitHub<#71 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABUFJGWMUJBSIP5MUJT62GLWE3DZTANCNFSM5MVHRTSA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sure, will do! My apologies for hijacking this issue. 😊 |
Hey Asterix!
If you're reading, I finally figured out how to make pull request on github!
I spent the last week to clean-up names and extra-files and I think the project may be ready for a merge!
I don't know if it's right, but I would suggest to have a backup copy of the original mod anyway, because I think it's best to preserve the work of those who made it before. But I hope this could be a further improvement overall!
Let me know!