Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to merge with official mod #71

Open
wants to merge 206 commits into
base: master
Choose a base branch
from

Conversation

stereotipo
Copy link
Contributor

Hey Asterix!
If you're reading, I finally figured out how to make pull request on github!
I spent the last week to clean-up names and extra-files and I think the project may be ready for a merge!
I don't know if it's right, but I would suggest to have a backup copy of the original mod anyway, because I think it's best to preserve the work of those who made it before. But I hope this could be a further improvement overall!
Let me know!

@tomasmatys
Copy link
Contributor

@StanleySweet i need your eyes here too

@7wells
Copy link

7wells commented Oct 23, 2022

@StanleySweet
Hi Stan, is 1000 A.D. currently developed in GitHub? It has been a while ago that I was involved in the base game 0 A.D. (forum name "Ceres"), and recently I was very much delighted to see the new 0 A.D. release. 🙂 Our kids wanted to add the 1000 A.D. mod, which now plays nicely with the latest base game release and asked me many questions, e.g. why a certain civ shows the wrong art (of another civ) when starting the game. And that's why I looked here in GitHub, i.e. if it makes sense to report such things in GitHub (and potentially also contribute to squash some bugs), or whether this should rather happen in the forum. As I am more familiar with GitHab than with Phab, I could try to help here about 1000 A.D. (and I saw that a similar possibility now exists via the community mod of 0 A.D., if I understood it right). To sum it up: How can I contribute here to help with e.g. this PR? Thanks for your patience and my best wishes for you and all kind people involved. 👍

@StanleySweet
Copy link
Contributor

Hey @7wells nice to be reading from you. Yes you can definitely report issues and make PRs here! That is the case for all the other mods on 0ADmods. :)

@7wells
Copy link

7wells commented Oct 24, 2022

@StanleySweet
Why is the 0 A.D. Community mod at GitLab, whereas the other 0 A.D. mods are here at GitHub? Is a transition taking place, or have I overseen something?

PS:
I have forked the 0 A.D. Community mod at GitLab:
https://gitlab.com/7wells/0ad-community-mod-a26

@StanleySweet
Copy link
Contributor

StanleySweet commented Oct 24, 2022 via email

@7wells
Copy link

7wells commented Oct 25, 2022

Sure, will do! My apologies for hijacking this issue. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants