Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tools] Genesis Wizard #1243

Closed
wants to merge 219 commits into from
Closed

[Tools] Genesis Wizard #1243

wants to merge 219 commits into from

Conversation

0o-de-lally
Copy link
Collaborator

A wizard tool for running genesis from legacy data

@0o-de-lally
For 0L genesis tools for hard forks, and migrations: create a MoveVm …
1b18a7a 
…session from fake data to be able to apply migrations from Move system contracts.
@0o-de-lally
wip testing fakeexector for account migrations
4c5e0d2
@0o-de-lally
Scaffolding tests for v6 genesis fork. first cleanup deprecated modules.
4e1b6cb
@0o-de-lally
add fixtures for testing recovery genesis
d5b72e1
@0o-de-lally
cleanup fixtures
074636d 
implement functional tests for:
- exporting db backup to json
- creating genesis blob from json
- creating genesis blob in one shot from db backup

TODO: launch test node from from genesis.blob
TODO: e2e tests from a fixture file
@0o-de-lally
integration test using blob from fixture to start a diem-node in test…
8ca37d0 
… mode
@0o-de-lally
patch github actions tests
e1b75c6
@0o-de-lally
full e2e test from db backup to starting a node
757648c
@0o-de-lally
Add diem_logger as per @corythian plus comments.
19bd78f
@0o-de-lally
query nodes to check if onchain state is the same as recovery.
1e5f1c6
@0o-de-lally
- include db reader util to inspect a genesis.blob.
270f569 
- refactor recovery tests
@0o-de-lally
test to check validator count. cleanup test utlis
c5b9fa4
@0o-de-lally
cleanup tests
e7df8b6
@0o-de-lally
stub a "check" feature, to check a json file agains the output genesi…
66c4ffe 
…s.blob
@0o-de-lally
finish balance comparison with error list.
203ac54
@0o-de-lally
clean
7c43037
@0o-de-lally
test to create single validator and check output.
12e6479
@0o-de-lally
skip comparing system zero address.
6bc8809
@0o-de-lally
cargo fix
6156a0b
@0o-de-lally
cargo fmt
6da792c
@0o-de-lally
create function to start a vm executor, and uses a function pointer t…
6a4f3d6 
…o transform legacy data to Move arguments.
@0o-de-lally
experimenting with alternative way of starting a vm genesis session
886bec0
@0o-de-lally
runs
1766888
@0o-de-lally
cleanup
f0b6c3b
@0o-de-lally
need to explicitly set the validators at genesis
6cbe210
@0o-de-lally
test to confirm genesis validator set, is the same as defined set.
395568c
@0o-de-lally
tests for validator set and balance passing
fded61e
@0o-de-lally
change fixtures, make node start from command line
e1c43b0
@0o-de-lally
can start a test node from genesis blob
979e811
@0o-de-lally
can genesis tools test can start a node from a genesis and query for …
20590e0 
…an accounts resources
@0o-de-lally
Copy link
Collaborator Author

cc @nimadebi

@sirouk
Copy link
Contributor

sirouk commented Mar 10, 2023

LGTM, thanks!

@sirouk sirouk marked this pull request as ready for review March 10, 2023 20:56
sirouk
sirouk approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@sirouk sirouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work!

sirouk
sirouk approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@sirouk sirouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sirouk
sirouk approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@sirouk sirouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0o-de-lally
Cleanups from PR reviews.
b8b1f9f
@0o-de-lally
Squashed commit of the following:
8dbed40 
commit 3f413f1
Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
Date:   Tue Apr 11 10:45:57 2023 -0400

    Squashed commit of the following:

    commit b8b1f9f
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Wed Apr 5 10:46:25 2023 -0400

        Cleanups from PR reviews.

    commit de52c39
    Merge: cdfdfc5 72ceae8
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Wed Mar 29 20:39:58 2023 -0400

        Merge pull request #4 from nimadebi/v6-0d-wizard-genesis

        V6 0d wizard genesis

    commit 72ceae8
    Author: nimadepi <nakib@live.nl>
    Date:   Sun Mar 19 13:05:56 2023 +0100

        clean up

    commit 259cad6
    Author: nimadepi <nakib@live.nl>
    Date:   Sun Mar 19 12:57:40 2023 +0100

        add node files generation

    commit cdfdfc5
    Merge: 2363875 40e9732
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Fri Mar 10 15:13:52 2023 -0500

        Merge pull request #3 from nimadebi/v6-0d-wizard-genesis

        V6 0d wizard genesis

    commit 40e9732
    Author: nimadepi <nakib@live.nl>
    Date:   Sun Mar 5 23:12:26 2023 +0100

        cleanup comments

    commit 92001c3
    Author: nimadepi <nakib@live.nl>
    Date:   Sun Mar 5 22:54:33 2023 +0100

        create 0L folder when gh keys entered

    commit 7fdda59
    Author: nimadepi <nakib@live.nl>
    Date:   Sat Mar 4 22:13:08 2023 +0100

        fixed total process

    commit 04df840
    Author: nimadepi <nakib@live.nl>
    Date:   Sat Mar 4 19:57:14 2023 +0100

        cleanup

    commit ed5a998
    Author: nimadepi <nakib@live.nl>
    Date:   Sat Mar 4 15:37:21 2023 +0100

        fix snapshot path

    commit dcbe647
    Author: nimadepi <nakib@live.nl>
    Date:   Sat Mar 4 14:53:08 2023 +0100

        fix

    commit f7e8887
    Author: nimadepi <nakib@live.nl>
    Date:   Sat Mar 4 13:48:24 2023 +0100

        fix

    commit 4f656f1
    Author: nimadepi <nakib@live.nl>
    Date:   Sat Mar 4 13:32:10 2023 +0100

        check for existing snapshot

    commit 2363875
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Fri Mar 3 10:06:13 2023 -0500

        complete all features of genesis wizard

    commit b66a1d5
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Thu Mar 2 17:26:27 2023 -0500

        workflow patches

    commit e15a42a
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Thu Mar 2 17:16:23 2023 -0500

        save api key

    commit 4496eb8
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Thu Mar 2 16:54:28 2023 -0500

        makefile

    commit b573d14
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Thu Mar 2 16:50:59 2023 -0500

        revert makefile

    commit 1afc03c
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Thu Mar 2 16:39:11 2023 -0500

        cleanup

    commit 7867a7d
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Thu Mar 2 16:28:35 2023 -0500

        cleanup

    commit a802d14
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Thu Mar 2 17:26:27 2023 -0500

        workflow patches

    commit 9483386
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Thu Mar 2 15:45:49 2023 -0500

        patch

    commit b093c9b
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Thu Mar 2 15:31:05 2023 -0500

        cleanup

    commit dbc6cc3
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Thu Mar 2 15:26:36 2023 -0500

        fix

    commit 8375271
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Thu Mar 2 15:26:11 2023 -0500

        wizard runs genesis.

    commit 78cb948
    Merge: 121b95a 0a24808
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Thu Mar 2 14:47:52 2023 -0500

        Merge pull request #1 from nimadebi/v6-0d-wizard-genesis

        V6 0d wizard genesis

    commit 0a24808
    Author: nimadepi <nakib@live.nl>
    Date:   Thu Mar 2 17:40:00 2023 +0100

        add epoch

    commit e2c2709
    Author: nimadepi <nakib@live.nl>
    Date:   Wed Mar 1 23:27:24 2023 +0100

        add genesis pull request

    commit 3070000
    Author: nimadepi <nakib@live.nl>
    Date:   Wed Mar 1 22:11:30 2023 +0100

        send validator config to github

    commit b060fa8
    Author: nimadepi <nakib@live.nl>
    Date:   Wed Mar 1 18:02:43 2023 +0100

        add validator config struct

    commit 121b95a
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Tue Feb 28 20:44:38 2023 -0500

        patches. uses correct git account

    commit be42125
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Tue Feb 28 20:18:27 2023 -0500

        cleanup

    commit 034ed5c
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Tue Feb 28 18:12:14 2023 -0500

        gross refactoring to make the github genesis work as a library

    commit 1da22f6
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Tue Feb 28 14:42:13 2023 -0500

        refactoring onboard

    commit a48e1a1
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Tue Feb 28 14:07:43 2023 -0500

        refactoring onboardin

    commit 101d317
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Tue Feb 28 13:42:05 2023 -0500

        wip

    commit 3fbe012
    Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
    Date:   Tue Feb 28 13:30:15 2023 -0500

        scaffold for genesis wizard

commit 2b21aa4
Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
Date:   Wed Mar 1 20:44:03 2023 -0500

    patch txs client response handling
@0o-de-lally 0o-de-lally mentioned this pull request Apr 11, 2023
Closed
8 tasks
@0xzoz
Copy link
Collaborator

0xzoz commented Jul 6, 2023

Closing due to changes included #1261

@0xzoz 0xzoz closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simsekgokhan simsekgokhan simsekgokhan left review comments

@sirouk sirouk sirouk approved these changes

@hemulin hemulin Awaiting requested review from hemulin

@agouin agouin Awaiting requested review from agouin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@0o-de-lally @sirouk @0xzoz @simsekgokhan @nonast