fix: use mypy.ignore_missing_imports instead of suppressing them everywhere manually #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yedpodtrzitko
force-pushed
the
yed/mypy-ignore-missing-imports
branch
from
b5970c2
to
cc84ea7
Compare
yedpodtrzitko
commented
Jul 22, 2022
| @@ -194,7 +194,8 @@ def validate( | |||
| before(request, response, req_validation_error, None) | |||
| if req_validation_error: | |||
| after(request, response, req_validation_error, None) | |||
| abort(response) # type: ignore | |||
| assert response # make mypy happy | |||
| abort(response) | |||
There was a problem hiding this comment.
This was weird. Removing type: ignore here passed when running it on my machine, but it was raising error when running here. When I put it back, it was complaining about unused ignore. So the way how to oveercome it was to make sure the response is not Optional.
There was a problem hiding this comment.
Sometimes that happens even if the Python and mypy versions are the same. I'm not sure about the root cause.
kemingy
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems like these mypy errors are the last thing making the pipeline fail in #225. Instead of adding
type: ignoreto all newly added imports there, it would be better to disable these errors in one place. This PR is doing that.ignore_missing_importsdescription in mypy docs:https://mypy.readthedocs.io/en/stable/config_file.html#confval-ignore_missing_imports