Fix openapi >=3 versions compatibility #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
format code
supprt flask x-www-form-urlencoded
support flask multipart/form-data
support pypy
release v0.3.14
cgaunet
force-pushed
the
fix-openapi-3-compatibility
branch
from
7a1d15f
to
0ab3477
Compare
cgaunet
force-pushed
the
fix-openapi-3-compatibility
branch
from
0ab3477
to
256edd4
Compare
|
LGTM. Thanks for your contribution. |
xordoquy
added a commit
to pass-culture/pass-culture-api
that referenced
this pull request
Dec 11, 2020
Spectree has a small imcompatibility with the OpenAPI 3.0.3:
Nested models are generated as `/definitions/{model}` while
no such path exists within OpenAPI 3.0.x
All models should be under `/components/schemas/`.
While this has been reported and fixed upstream with PR:
0b01001001/spectree#91
we need to fix it while waiting the proper solution.
xordoquy
added a commit
to pass-culture/pass-culture-api
that referenced
this pull request
Dec 11, 2020
Spectree has a small imcompatibility with the OpenAPI 3.0.3:
Nested models are generated as `/definitions/{model}` while
no such path exists within OpenAPI 3.0.x
All models should be under `/components/schemas/`.
While this has been reported and fixed upstream with PR:
0b01001001/spectree#91
we need to fix it while waiting the proper solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG]:
When generating the openAPI JSON document, it put Pydantic definitions in a part called "definitions". This is deprecated and not compatible with openAPI versions superior to 3.
This Pull Request aims to bring back compatibility between the openapi.json generated and the specifications of openAPI V3
This is now possible thanks to pydantic/pydantic#1479
Thank you a lot for your awesome library that helps us on https://github.com/pass-culture/pass-culture-api to coordinate the 3 frontend apps and the api.
I hope that you will enjoy this contribution :)