Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid #6

Closed
Neebly opened this issue Apr 28, 2024 · 9 comments
Closed

F-Droid #6

Neebly opened this issue Apr 28, 2024 · 9 comments

Comments

@Neebly
Copy link

Neebly commented Apr 28, 2024

Please, submit your fantastic app to F-Droid repositories:
https://f-droid.org/en/docs/Submitting_to_F-Droid_Quick_Start_Guide/

@0bbedCode
Copy link
Owner

Will work on this when I have time I also need to check XDA , I am very busy at times not always but at times. Will do this !

@ThreeDeeJay
Copy link

Is the source code ready to compile?
Perhaps @IzzySoft can help putting it up on his repository 🤔

@IzzySoft
Copy link

Seems to be a fork of XPrivacyLua (as the repo properly reflects, thanks for keeping the connection!), and still uses its packageName (eu.faircode.xlua) which is an issue – unless Marcel transferred ownership to you. If that happened, can you please point it out? If not, a different package name would be needed (e.g. 0bbedCode.xplex). Then it can be added to IzzyOnDroid, scanner results look fine!

@0bbedCode
Copy link
Owner

Seems to be a fork of XPrivacyLua (as the repo properly reflects, thanks for keeping the connection!), and still uses its packageName (eu.faircode.xlua) which is an issue – unless Marcel transferred ownership to you. If that happened, can you please point it out? If not, a different package name would be needed (e.g. 0bbedCode.xplex). Then it can be added to IzzyOnDroid, scanner results look fine!

will this be an issue to F-Droid since I dont own it ?

@ThreeDeeJay
Copy link

If that's gonna be a problem, I'd be okay with just adding a GitHub actions CI workflow to get automated APK builds from GitHub releases using Obtainium to make it easier for everyone 👌

@IzzySoft
Copy link

IzzySoft commented Jun 9, 2024

will this be an issue to F-Droid since I dont own it ?

Yes. Especially as there already is an app using this packageName, so there'd be a conflict. Basically, keeping the packageName means you're pretending to be the legal successor – but this is a different app, so it should have its own packageName.

@ThreeDeeJay
Copy link

@0bbedCode @IzzySoft I tried setting up a GitHub actions workflow but I'm getting some compilation errors.
This usually works with other apps, but perhaps I'm missing something.🤔
Do you guys have a way to compile the APK programmatically via the command line so I can try to port it to the CI?
Also the main XPL-EX repo would probably need to add the signing keys to secrets so they're called privately and we can keep the same APK signature across builds to be able to update without having to uninstall the old version first.
That is, at least while the F-Droid situation gets sorted out 👌

@ThreeDeeJay
Copy link

Found a fork that figured out how to build the APK https://github.com/Fearlein/XPL-EX-CANARY/actions/runs/9436761981
So I guess now we just need to figure out how to make it use @0bbedCode's signing keys instead of whatever's going on here and make it push new APKs for each update to GitHub releases, so then we can just use something like Obtainium to get updates.

@IzzySoft
Copy link

IzzySoft commented Jul 8, 2024

Sorry, I can't help with that: I'm no Android dev, and also not familiar with the CI here…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants