Skip to content
This repository has been archived by the owner on Sep 12, 2020. It is now read-only.

The order of the Search Shortcuts inside the drop down doesn't correspond with the order from the new tab page #3

Closed
SoftVision-CarmenFat opened this issue Aug 21, 2019 · 3 comments
Labels
firefox bug wontfix This will not be worked on

Comments

@SoftVision-CarmenFat
Copy link

[Affected Versions]:

  • Dev Edition 69.0b15

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • The "Search Top Sites" test recipe is created and published.

[Steps to reproduce]:

  1. Open a Developer Edition 69.0b15 profile that can be targeted by the previously set recipe.
  2. Navigate to a website (e.g. www.example.com).
  3. Click the URL and observe the drop down websites.

[Expected results]:

  • The Top Sites are displayed in the same order as in the "about:newtab" page.

[Actual results]:

  • The Amazon Search Shortcut is placed first in the Top Sites list.

[Notes]:

  • This issue is also reproducible with other Search Shortcuts.
  • Please see the following screencast of the issue:

search shortcut

@0c0w3
Copy link
Owner

0c0w3 commented Aug 21, 2019

We're going to have to live with this one, at least for the experiment's initial rollout in 69.

This is due to the sorting that UrlbarMuxerUnifiedComplete does, in the product. It's not something the add-on can change. It sorts search results, which includes keyword offers, above (most) everything else.

@0c0w3 0c0w3 added the wontfix This will not be worked on label Aug 22, 2019
@0c0w3
Copy link
Owner

0c0w3 commented Aug 27, 2019

I'm going to close these wontfix bugs so they get off my dashboard. Thanks for filing them though. For this particular one, we have a corresponding Bugzilla bug for fixing it in the product iirc (the ability for extensions to define their own muxers).

@0c0w3
Copy link
Owner

0c0w3 commented Aug 27, 2019

https://bugzilla.mozilla.org/show_bug.cgi?id=1547287 is the bug. I added a comment there about this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firefox bug wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants