Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect entityMetadataMap from concurrent access #197

Closed
Sriep opened this issue Apr 20, 2021 · 0 comments · Fixed by #214
Closed

Protect entityMetadataMap from concurrent access #197

Sriep opened this issue Apr 20, 2021 · 0 comments · Fixed by #214
Assignees
@platsko
Labels
bug

Comments

@Sriep
Copy link
Contributor

Sriep commented Apr 20, 2021 •
edited

entityMetadataMap is a global map accessed from numerous files across the project. It should be protected from concurrent access.

Adding a RWMutex to RegisterEntityMetadata and GetEntityMetadata should be sufficient.

This causes a race issue when running go test -race on the /0chain/code/go/0chain.net/sharder/blockstore/ directory.
@Sriep Sriep changed the title Protect entityMetadataMap from concurrent access. Protect entityMetadataMap from concurrent access Apr 20, 2021
@Sriep Sriep added the bug label Apr 20, 2021
@Sriep Sriep removed their assignment Apr 27, 2021
platsko added a commit that referenced this issue Apr 29, 2021
@platsko
Protect entityMetadataMap from concurrent access #197
525f6e9
@platsko platsko mentioned this issue Apr 29, 2021
Merged
platsko added a commit that referenced this issue Apr 29, 2021
@platsko
Protect entityMetadataMap from concurrent access #197
74e457f 
- code clean & decompose
@platsko platsko self-assigned this Apr 30, 2021
platsko added a commit that referenced this issue May 2, 2021
@platsko
Protect entityMetadataMap from concurrent access #197
f0d0643 
- revert go.mod & go.sum
@Sriep Sriep closed this as completed in #214 May 2, 2021
Sriep pushed a commit that referenced this issue May 2, 2021
@platsko
Protect entityMetadataMap from concurrent access #197 (#214)
3c1da95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@platsko platsko

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Protect entityMetadataMap from concurrent access #197 0chain/0chain
2 participants
@platsko @Sriep