Feature/unit test interestpoolsc #112
Conversation
There was a problem hiding this comment.
New errors
this branch: https://www.0chain-ci.net/root/0chain/-/jobs/2516/raw
master: https://www.0chain-ci.net/root/0chain/-/jobs/2545/raw
this test case fails in master too, but with different error:
fatal error: concurrent map writes
goroutine 137 [running]:
runtime.throw(0xc77964, 0x15)
/usr/local/go/src/runtime/panic.go:617 +0x72 fp=0xc000497578 sp=0xc000497548 pc=0x4436f2
# about 500 lines of errors with goroutines
FAIL 0chain.net/sharder/blockstore
panic: fatal error config file: Config File "sc" Not Found in "[/0chain/go/0chain.net/smartcontract/interestpoolsc/config]" [recovered]
panic: fatal error config file: Config File "sc" Not Found in "[/0chain/go/0chain.net/smartcontract/interestpoolsc/config]"
goroutine 86 [running]:
# ...
FAIL 0chain.net/smartcontract/interestpoolsc 0.049s
Also, please note that there is massive refactoring in fees.go in another branch:
https://github.com/0chain/0chain/tree/fix/fees-test
| } | ||
| ie, ok := objMap["tokens_earned"] | ||
| if ok { | ||
| var earned state.Balance |
There was a problem hiding this comment.
I know there is no generics in Golang, but can we avoid copy-pasting? We can create a utility module for encoding/decoding since it looks to be quite pervasive.
There was a problem hiding this comment.
Error fatal error config file: Config File "sc" Not Found caused because in this package there is no configuration directory.
I have already added
COPY ./config/sc.yaml $SRC_DIR/go/0chain.net/smartcontract/interestpoolsc/config/
Be sure please that you can find it in your docker.local/build.sc_unit_test/Dockerfile
I think it makes no sense to create a separate package for encoding/decoding because there, for different structures, the encoding/decoding is done in different ways.
And what don't you like here? )
There was a problem hiding this comment.
The error I reported above is from our CI server, not from my local machine.
If some configuration needs to be made, then it should be committed.
CI server runs unit tests with ./docker.local/bin/unit_test.sh --ci.
About copy-paste — nevermind, I've already realized it is difficult to avoid it in Go :)
There was a problem hiding this comment.
To run the smart-contract unit test I use sc_unit_test.sh.
There was a problem hiding this comment.
We need to merge this first then:
#127
My question: In .2 above Does this PR fix any issues with 0chian or otherwise change its behaviour, or is it just refactoring? |
| SmartContract: tt.fields.SmartContract, | ||
| } | ||
| if tt.shouldBeOk { | ||
| config.SetupSmartContractConfig() |
There was a problem hiding this comment.
TestInterestPoolSmartContract_updateVariables fails because config.SetupSmartContractConfig is expecting a config directory with a sc.??? file in, which is missing.
Elsewhere config.SetupSmartContractConfig is only used in production code.
The sc config needs to be mocked somehow.
There was a problem hiding this comment.
Why do you want to mock config? this does not change the state of the application, it only sets the input parameters
There was a problem hiding this comment.
TestInterestPoolSmartContract_updateVariables fails because config.SetupSmartContractConfig is expecting a config directory with a sc.??? file in, which is missing.
Some change is needed to stop the unit test from failing at this point.
I do not want a mock config. There just needs to be some change so that the unit test works. A mock config looked like one possible solution to me, but whatever works.
|
|
@Sriep @gasparyanyur is this closed? |
|
Still awaiting a fix for the issue mentioned by @kirillt and @Sriep above. Plus merge conflicts. Also, it's been a while, so some confounding changes might cause problems. |
|
@gasparyanyur Please resolve the conflicts. |
guruhubb
requested review from
Kenwes13
and removed request for
platsko and
MurashovVen
…nterestpoolsc # Conflicts: # code/go/0chain.net/smartcontract/setupsc/setupsc.go # docker.local/bin/unit_test.sh # docker.local/build.sc_unit_test/Dockerfile
No description provided.