state_context.go fix for smartcontgract/storatec #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sriep
reviewed
Mar 22, 2021
|
|
||
| key_hash := encryption.Hash(key) | ||
|
|
||
| if !encryption.IsHash(key_hash) { |
There was a problem hiding this comment.
Can this test ever fail? You have just created key_hash to be a hash so isn't it always a hash? Same for insert and delete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an incompatibility between the GetKey functions in the file:
https://github.com/0chain/0chain/blob/master/code/go/0chain.net/smartcontract/storagesc/models.go
and the IsHash function:
0chain/code/go/0chain.net/core/encryption/hash.go
Line 22 in 378cc81
IsHash wants HASH_LENGTH = 32
But GetKey functions add an arbitrary number of bytes to the HASH_LENGTH.
Regression tests were made:
create allocation
upload file to allocation.
./zbox listallocations