Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an extra check to pull requests to run all the unit tests. This takes an extra 10 minutes on each pull request but helps prevent problem code from entering the master branch.
In order for the master branch to pass unit test checks, several failing unit tests have been deactivated. An issue #130 has been created to fix them.
There is a decision whether to use the
-v
verbose option in thego test
. Currently not set as at the moment the output consists mostly of dumps of PMT databases which obscure everything else, and fills up the output buffer. However, the -v off output only shows pass or fail with no indication of why. Once the unnecessary unit-test output is removed as suggested in issue #130 the-v
option could be added.When running without the
-v
option I sometimes get concurrent access issues indicating problems with race conditions. I raised a separate issue #131 to investigate these.m_handler.go