Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minersc payFes: fix sharder delegate reward and view change interest #142

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented Apr 2, 2021

Fix a couple of issues in fees.go.

  • The service change for sharder delegates was wrong. The service charge was not being removed. This was also fixed in PR Fixing rewards and fees + fees_test, lots of refactoring and other small fixes #117 but that came with extensive refactoring. This aims to change as little as possible.
  • Interest payments not being paid. Now interest payments are paid every multiple of sc.minersc.reward_round_frequency, this is the same irrespective of the view_change setting. There is an alternative approach of paying interest when 0chian.view_change = true which will mostly work out the same.

Resolves issue indicated by unit test PR #137 which cannot be merged until this PR is merged.

@Sriep Sriep changed the title fix interest and sharder delegate issues with payFees Minersc payFes: fix sharder delegate reward and view change interest Apr 2, 2021
@Sriep Sriep requested review from kirillt, peterlimg, MurashovVen and TheTeaParty and removed request for kirillt April 3, 2021 16:22
@Sriep Sriep merged commit ddb43ab into master Apr 9, 2021
@platsko platsko deleted the fix-payfee branch May 9, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant