Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single go.mod For Project #162

Merged
merged 8 commits into from
Apr 27, 2021
Merged

Single go.mod For Project #162

merged 8 commits into from
Apr 27, 2021

Conversation

TheTeaParty
Copy link
Contributor

@TheTeaParty TheTeaParty commented Apr 7, 2021 •
edited

Closes #141

@TheTeaParty TheTeaParty linked an issue Apr 7, 2021 that may be closed by this pull request
Single go.mod For Project #141
Closed
@TheTeaParty TheTeaParty requested a review from kirillt April 7, 2021 15:24
@TheTeaParty TheTeaParty marked this pull request as draft April 7, 2021 15:27
@TheTeaParty TheTeaParty requested a review from Sriep April 7, 2021 15:27
@TheTeaParty TheTeaParty changed the title [WIP] Single go.mod for project Single go.mod for project Apr 7, 2021
@TheTeaParty TheTeaParty marked this pull request as ready for review April 7, 2021 17:02
@TheTeaParty TheTeaParty changed the title Single go.mod for project Single go.mod For Project Apr 8, 2021
@Sriep
Copy link
Contributor

Sriep commented Apr 8, 2021 •
edited

My main concern is how this change affects the scripts in 0chain\docker.local\bin. So search on go.mod gives:

unit_test_build.sh now works mostly by accident and should be revised. It's being used actively in unit test check.

linter.sh I don't think this is used at the moment but is part of the temporarily deactivated lint check. Sachin Joshi is working on this, probably ok to just let him know.

@TheTeaParty
Copy link
Contributor Author

My main concern is how this change affects the scripts in 0chain\docker.local\bin. So search on go.mod gives:

unit_test_build.sh now works mostly by accident and should be revised. It's being used actively in unit test check.

linter.sh I don't think this is used at the moment but is part of the temporarily deactivated lint check. Sachin Joshi is working on this, probably ok to just let him know.

Agree will fix unit_test_build.sh I might mised it.

@Sriep Sriep mentioned this pull request Apr 9, 2021
Closed
@guruhubb guruhubb removed the request for review from kirillt April 18, 2021 19:04
@TheTeaParty TheTeaParty merged commit fdf5d9e into master Apr 27, 2021
@TheTeaParty TheTeaParty deleted the feat/single-go-mod branch April 29, 2021 01:23
This was referenced Apr 29, 2021
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sriep Sriep Sriep approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single go.mod For Project
2 participants
@TheTeaParty @Sriep