Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes leftover changes #1682

Merged
merged 1 commit into from Sep 18, 2022
Merged

Conversation

0xhrsh
Copy link
Contributor

@0xhrsh 0xhrsh commented Sep 18, 2022

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@0xhrsh 0xhrsh mentioned this pull request Sep 18, 2022
3 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #1682 (8f18a34) into staging (5bb85ff) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           staging    #1682      +/-   ##
===========================================
- Coverage    26.64%   26.62%   -0.02%     
===========================================
  Files          346      346              
  Lines        56533    56534       +1     
===========================================
- Hits         15063    15054       -9     
- Misses       39642    39658      +16     
+ Partials      1828     1822       -6     
Flag Coverage 螖
Unit-Tests 26.62% <66.66%> (-0.02%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
code/go/0chain.net/smartcontract/zcnsc/models.go 50.89% <63.63%> (+0.89%) 猬嗭笍
code/go/0chain.net/smartcontract/zcnsc/mint.go 47.95% <75.00%> (+1.08%) 猬嗭笍
...de/go/0chain.net/smartcontract/vestingsc/config.go 49.22% <0.00%> (-6.22%) 猬囷笍
...ain.net/smartcontract/storagesc/config_settigns.go 32.50% <0.00%> (酶)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit ea4273c into staging Sep 18, 2022
@0xhrsh 0xhrsh deleted the 0xhrsh/zcnsc-check-sign-threshold-extended branch September 28, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants