Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switches for verbosity and profiling #1701

Merged
merged 2 commits into from Oct 2, 2022

Conversation

iamrz1
Copy link
Contributor

@iamrz1 iamrz1 commented Sep 25, 2022

Fixes

#1636
#467

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2022

Codecov Report

Merging #1701 (bd1fb04) into staging (c9aa085) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           staging    #1701      +/-   ##
===========================================
+ Coverage    26.86%   26.88%   +0.01%     
===========================================
  Files          346      346              
  Lines        56743    56740       -3     
===========================================
+ Hits         15245    15255      +10     
+ Misses       39640    39622      -18     
- Partials      1858     1863       +5     
Flag Coverage Δ
Unit-Tests 26.88% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
code/go/0chain.net/chaincore/transaction/entity.go 0.72% <0.00%> (+<0.01%) ⬆️
code/go/0chain.net/core/datastore/worker.go 97.26% <0.00%> (-2.74%) ⬇️
...ain.net/smartcontract/storagesc/config_settigns.go 32.50% <0.00%> (ø)
...de/go/0chain.net/smartcontract/vestingsc/config.go 58.54% <0.00%> (+6.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

code/go/0chain.net/miner/miner/main.go Outdated Show resolved Hide resolved
@dabasov
Copy link
Member

dabasov commented Sep 25, 2022

@iamrz1 I've found this, we should log txn also

return debugState >= DebugLevelTxn

code/go/0chain.net/miner/miner/main.go Show resolved Hide resolved
code/go/0chain.net/miner/miner/main.go Outdated Show resolved Hide resolved
Fixed pprof port
@iamrz1
Copy link
Contributor Author

iamrz1 commented Sep 26, 2022

@iamrz1 I've found this, we should log txn also

return debugState >= DebugLevelTxn

Added. Please check.

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iamrz1
Copy link
Contributor Author

iamrz1 commented Sep 28, 2022

I can't merge PRs on 0chain, please merge if there's no further reviews.

@peterlimg
Copy link
Member

@iamrz1 please check new comments

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peterlimg peterlimg merged commit 1144e11 into staging Oct 2, 2022
@peterlimg peterlimg deleted the development-log-profiling branch October 2, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants