Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow update existing stake pool when at max delegates #1832

Merged
merged 1 commit into from Nov 24, 2022

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented Nov 23, 2022

Fixes

Allows a delegate to lock tokens to an existing pool, when the stake pool has the maximum number of delegates.
Removes some dead code.

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@Sriep Sriep mentioned this pull request Nov 23, 2022
3 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #1832 (b8317c7) into staging (9b5e165) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           staging    #1832   +/-   ##
========================================
  Coverage    26.42%   26.43%           
========================================
  Files          355      355           
  Lines        59067    59063    -4     
========================================
+ Hits         15608    15611    +3     
+ Misses       41559    41550    -9     
- Partials      1900     1902    +2     
Flag Coverage 螖
Unit-Tests 26.43% <0.00%> (+<0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...0chain.net/smartcontract/minersc/delegate_pools.go 0.00% <0.00%> (酶)
...go/0chain.net/smartcontract/stakepool/stakepool.go 18.12% <0.00%> (+0.21%) 猬嗭笍
...go/0chain.net/smartcontract/storagesc/stakepool.go 34.59% <0.00%> (酶)
...ode/go/0chain.net/smartcontract/zcnsc/stakepool.go 35.66% <0.00%> (酶)
...ain.net/smartcontract/storagesc/config_settigns.go 54.76% <0.00%> (酶)
...de/go/0chain.net/smartcontract/vestingsc/config.go 50.52% <0.00%> (+1.57%) 猬嗭笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterlimg peterlimg merged commit 600a662 into staging Nov 24, 2022
@peterlimg peterlimg deleted the fix_lock_at_max branch November 24, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants