Add missing config and initial staking #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## staging #1837 +/- ##
===========================================
- Coverage 26.86% 26.84% -0.02%
===========================================
Files 356 356
Lines 59197 59257 +60
===========================================
+ Hits 15904 15909 +5
- Misses 41386 41439 +53
- Partials 1907 1909 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
iamrz1
force-pushed
the
0chain-1755
branch
3 times, most recently
from
5546fd8
to
fcbf86a
Compare
peterlimg
requested changes
Nov 29, 2022
peterlimg
requested changes
Dec 3, 2022
iamrz1
force-pushed
the
0chain-1755
branch
2 times, most recently
from
8012a45
to
02d98e2
Compare
Before we implemented code to stop genesis block re-entering, genesis block generationg code will be called everytime when node starts, so staking would aleady exist, and we need to continue instead of returning to cause panic.
peterlimg
approved these changes
Dec 9, 2022
* staging: (32 commits) fix: remove check for lfb fix: check for round/lfb before genesis setup make rm and wm hash different make rm and wm hash different make rm and wm hash different make rm and wm hash different merge PR1873 fix fix wirtemarker tx hash touch touch lock network until all nodes are ready on miner fault tolerance test remove commented code lock network until all nodes are registered in fault tolerance test touch add type to fee reward remove debug line reduce bank data list length reduce bank data list length reduce bank data list length ...
peterlimg
approved these changes
Dec 9, 2022
|
Manual system tests [success] with the following config
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#1700
#1707
Changes
Need to be mentioned in CHANGELOG.md?
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):