Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock network until all nodes are registered in fault tolerance test #1851

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

fabioDMFerreira
Copy link
Contributor

Fixes

  • Fault tolerance test Sharder goes down for 3 minutes simultaneously with coming up of the previous one

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge staging code to avoid sharders load snapshot panic during system tests

code/go/0chain.net/conductor/conductor/executor.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2022

Codecov Report

Merging #1851 (26d0e5a) into staging (01d2ccc) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           staging    #1851      +/-   ##
===========================================
- Coverage    26.86%   26.84%   -0.03%     
===========================================
  Files          356      356              
  Lines        59197    59197              
===========================================
- Hits         15904    15889      -15     
- Misses       41386    41409      +23     
+ Partials      1907     1899       -8     
Flag Coverage 螖
Unit-Tests 26.84% <酶> (-0.03%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...de/go/0chain.net/smartcontract/vestingsc/config.go 48.94% <0.00%> (-7.90%) 猬囷笍
...ain.net/smartcontract/storagesc/config_settigns.go 54.76% <0.00%> (酶)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fabioDMFerreira fabioDMFerreira force-pushed the fix/fault-tolerance-tests-network-locking branch from dd64987 to 26d0e5a Compare December 5, 2022 08:54
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabioDMFerreira
Copy link
Contributor Author

@peterlimg the system tests are failing. I don't think the changes have any relation to the failure. Could you merge this PR?

@fabioDMFerreira fabioDMFerreira force-pushed the fix/fault-tolerance-tests-network-locking branch from 26d0e5a to 4e7e9e7 Compare December 6, 2022 09:54
@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain fix/fault-tolerance-tests-network-locking
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@peterlimg peterlimg merged commit 34df75f into staging Dec 8, 2022
@peterlimg peterlimg deleted the fix/fault-tolerance-tests-network-locking branch December 8, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants