-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
lock network until all nodes are registered in fault tolerance test #1851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge staging code to avoid sharders load snapshot panic during system tests
Codecov Report
@@ Coverage Diff @@
## staging #1851 +/- ##
===========================================
- Coverage 26.86% 26.84% -0.03%
===========================================
Files 356 356
Lines 59197 59197
===========================================
- Hits 15904 15889 -15
- Misses 41386 41409 +23
+ Partials 1907 1899 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dd64987
to
26d0e5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@peterlimg the system tests are failing. I don't think the changes have any relation to the failure. Could you merge this PR? |
26d0e5a
to
4e7e9e7
Compare
Manual system tests [success] with the following config
|
Fixes
Sharder goes down for 3 minutes simultaneously with coming up of the previous one
Need to be mentioned in CHANGELOG.md?
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):