Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new aggeregates #1872

Merged
merged 7 commits into from
Dec 10, 2022
Merged

Added new aggeregates #1872

merged 7 commits into from
Dec 10, 2022

Conversation

manasnisar
Copy link
Contributor

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

Codecov Report

Merging #1872 (a3df699) into staging (34df75f) will decrease coverage by 0.01%.
The diff coverage is 3.33%.

@@             Coverage Diff             @@
##           staging    #1872      +/-   ##
===========================================
- Coverage    26.88%   26.86%   -0.02%     
===========================================
  Files          356      356              
  Lines        59195    59252      +57     
===========================================
+ Hits         15913    15921       +8     
- Misses       41377    41420      +43     
- Partials      1905     1911       +6     
Flag Coverage Δ
Unit-Tests 26.86% <3.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ode/go/0chain.net/chaincore/block/block_eventdb.go 0.00% <0.00%> (ø)
code/go/0chain.net/chaincore/chain/entity.go 10.17% <0.00%> (-0.02%) ⬇️
...de/go/0chain.net/chaincore/chain/protocol_block.go 0.00% <0.00%> (ø)
code/go/0chain.net/chaincore/chain/state.go 4.46% <0.00%> (-0.08%) ⬇️
code/go/0chain.net/miner/chain.go 22.89% <0.00%> (-0.19%) ⬇️
...e/go/0chain.net/smartcontract/dbs/event/process.go 1.86% <0.00%> (-0.03%) ⬇️
.../go/0chain.net/smartcontract/dbs/event/snapshot.go 0.00% <0.00%> (ø)
...ode/go/0chain.net/smartcontract/dbs/event/enums.go 88.76% <100.00%> (+0.25%) ⬆️
...ain.net/smartcontract/storagesc/config_settigns.go 54.76% <0.00%> (ø)
...de/go/0chain.net/smartcontract/vestingsc/config.go 58.42% <0.00%> (+3.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@manasnisar manasnisar changed the title WIP: Added new aggeregates Added new aggeregates Dec 8, 2022
@manasnisar manasnisar marked this pull request as ready for review December 8, 2022 08:34
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manasnisar
Copy link
Contributor Author

lgtm

Please merge.

@dabasov dabasov merged commit 7d3e6f0 into staging Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants