Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust redis connection parameters #1876

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

devyetii
Copy link
Collaborator

@devyetii devyetii commented Dec 8, 2022

Fixes

Changes

  • Fix the connection string to redis_txns

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@devyetii devyetii linked an issue Dec 8, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #1876 (7478382) into staging (34df75f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           staging    #1876      +/-   ##
===========================================
- Coverage    26.88%   26.86%   -0.02%     
===========================================
  Files          356      356              
  Lines        59195    59193       -2     
===========================================
- Hits         15913    15903      -10     
- Misses       41377    41385       +8     
  Partials      1905     1905              
Flag Coverage Δ
Unit-Tests 26.86% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
code/go/0chain.net/chaincore/transaction/entity.go 0.00% <0.00%> (-0.73%) ⬇️
...de/go/0chain.net/smartcontract/vestingsc/config.go 52.10% <0.00%> (-3.16%) ⬇️
code/go/0chain.net/chaincore/node/n2n_send.go 31.68% <0.00%> (-0.45%) ⬇️
...ain.net/smartcontract/storagesc/config_settigns.go 54.76% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain 1858-redis-is-crawling-the-ports-on-the-servers
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@peterlimg peterlimg merged commit 8d8b0aa into staging Dec 9, 2022
@shahnawaz-creator shahnawaz-creator deleted the 1858-redis-is-crawling-the-ports-on-the-servers branch January 28, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis is crawling the ports on the servers
4 participants