Fix bash in scripts #194
Merged
Fix bash in scripts #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbist
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
All changes look good.
One thing to note about docker.local/bin/unit_test.sh is that the expected order of flags and package name has changed. Previously, if a package and --sc flag were provided --sc flag was expected to come after the package name. Now --sc flag (if provided) should come before package name (if provided). I think the new one is better as it brings consistency to the usage of unit_test.sh.
If someone is using unit_test.sh locally, they may want to change the order of their flags and arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed shell scripts that make use of
[[ ]]to usebashas they don't work insh.Modified scripts as suggested by SC2199 to not use
$@in[[.Fixed
unit_test.sh, which was not working as intended.Resolves issue #176