Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcnsc fixes #2076

Merged
merged 1 commit into from Feb 2, 2023
Merged

zcnsc fixes #2076

merged 1 commit into from Feb 2, 2023

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented Feb 2, 2023 •
edited

Fixes

  • Benchmark test, mint2Confirmations, increment authoriser count for new authorises
  • Remove multiple inconsistent stake pool keys. Use key from stakepool package.
  • Benchmark add delegate pool, ensure transaction value exceeds min stake pool amount.
  • Benchmark, StakePoolRequest from stakepool package for tests..

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

dabasov
dabasov approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

peterlimg
peterlimg approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterlimg peterlimg merged commit 9c99496 into staging Feb 2, 2023
@peterlimg peterlimg deleted the fix_zcnsc branch February 2, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@peterlimg peterlimg peterlimg approved these changes

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sriep @dabasov @peterlimg