Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non genesis miners panic when there is no description #215

Merged
merged 1 commit into from
May 2, 2021

Conversation

Kenwes13
Copy link
Contributor

@Kenwes13 Kenwes13 commented Apr 30, 2021

Related tasks

Premise

A non genesis miner will panic if there isn't a description. The description isn't needed like the host or port are so returning a nil as the error will allow miners to join the network.

Changes

  • readNonGenesisHostAndPort no longer returns an error if there is no description

Allows miners to join network without description
@Sriep Sriep self-requested a review May 2, 2021 10:13
@Sriep Sriep merged commit 6e9d4c1 into master May 2, 2021
@Sriep Sriep deleted the descriptionPanic branch May 2, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants