Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty allocation root #2183

Merged
merged 3 commits into from Mar 4, 2023
Merged

Empty allocation root #2183

merged 3 commits into from Mar 4, 2023

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented Mar 1, 2023

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@dabasov dabasov added the bug label Mar 1, 2023
@dabasov dabasov requested a review from peterlimg as a code owner March 1, 2023 11:48
@dabasov dabasov self-assigned this Mar 1, 2023
@dabasov dabasov requested a review from guruhubb as a code owner March 1, 2023 11:49
@dabasov dabasov changed the title fixed selecting fresh allocation for challenges Empty allocation root Mar 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Merging #2183 (997388a) into staging (4277293) will increase coverage by 0.00%.
The diff coverage is 0.00%.

馃摚 This organization is not using Codecov鈥檚 GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           staging    #2183   +/-   ##
========================================
  Coverage    27.70%   27.71%           
========================================
  Files          375      375           
  Lines        61843    61843           
========================================
+ Hits         17136    17140    +4     
+ Misses       42651    42643    -8     
- Partials      2056     2060    +4     
Flag Coverage 螖
Unit-Tests 27.71% <0.00%> (+<0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...go/0chain.net/smartcontract/storagesc/challenge.go 36.71% <0.00%> (酶)
code/go/0chain.net/core/datastore/worker.go 97.26% <0.00%> (-2.74%) 猬囷笍
...ain.net/smartcontract/storagesc/config_settigns.go 54.76% <0.00%> (酶)
...de/go/0chain.net/smartcontract/vestingsc/config.go 58.42% <0.00%> (+3.15%) 猬嗭笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kishan-Dhakan Kishan-Dhakan merged commit fbdca4e into staging Mar 4, 2023
@Kishan-Dhakan Kishan-Dhakan deleted the fix/allocation-empty-roots branch March 4, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants