Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Test is failing after 3c1da95230feaa4819ec468cb6b3712a02ac1230 #229

Merged
merged 2 commits into from
May 7, 2021

Conversation

TheTeaParty
Copy link
Contributor

@TheTeaParty TheTeaParty commented May 3, 2021

Closes #228

  • removed invalid unit test

The entity setup for this test is done invalid. This requires redo sharder/block.go test redo. For now it is commented out.
The test have been dependent on other test so it was matter of timing either it will be successful or not

@TheTeaParty TheTeaParty requested review from platsko and Sriep May 3, 2021 00:31
code/go/0chain.net/sharder/block_test.go Outdated Show resolved Hide resolved
@TheTeaParty TheTeaParty requested a review from Sriep May 7, 2021 00:08
@Sriep Sriep merged commit 9c64373 into master May 7, 2021
@Sriep Sriep deleted the fix/bokern-commit-228 branch May 7, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Test is failing after 3c1da95230feaa4819ec468cb6b3712a02ac1230
2 participants