Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chaincore variables are colliding with imported packages #231

Merged
merged 12 commits into from
May 6, 2021
Merged

chaincore variables are colliding with imported packages #231

merged 12 commits into from
May 6, 2021

Conversation

TheTeaParty
Copy link
Contributor

Closes #230

@TheTeaParty TheTeaParty marked this pull request as draft May 3, 2021 01:33
@TheTeaParty TheTeaParty requested review from Sriep and platsko May 3, 2021 02:37
@TheTeaParty TheTeaParty marked this pull request as ready for review May 3, 2021 02:38
@Sriep
Copy link
Contributor

Sriep commented May 5, 2021

Looks promising, but needs to pass the unit test check. A dummy commit is needed to rerun the checks.

@Sriep Sriep merged commit c9b4a65 into master May 6, 2021
@Sriep Sriep deleted the feat/chaincore-imports branch May 6, 2021 12:19
@Sriep Sriep mentioned this pull request Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sriep Sriep Sriep approved these changes

@platsko platsko Awaiting requested review from platsko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chaincore variables are colliding with imported packages
2 participants
@TheTeaParty @Sriep