Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter getBlobbers and getValidators for is_killed and is_shutdown #2316

Merged
merged 15 commits into from May 4, 2023

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented Apr 19, 2023

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #2316 (d1e46b4) into staging (9dbb892) will increase coverage by 0.01%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging    #2316      +/-   ##
===========================================
+ Coverage    28.97%   28.98%   +0.01%     
===========================================
  Files          377      377              
  Lines        63065    63076      +11     
===========================================
+ Hits         18271    18285      +14     
+ Misses       42648    42639       -9     
- Partials      2146     2152       +6     
Flag Coverage Δ
Unit-Tests 28.98% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/go/0chain.net/smartcontract/dbs/event/blobber.go 32.13% <0.00%> (-0.69%) ⬇️
...go/0chain.net/smartcontract/dbs/event/validator.go 35.82% <0.00%> (-1.11%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kishan-Dhakan Kishan-Dhakan merged commit 69be8f2 into staging May 4, 2023
8 checks passed
@Kishan-Dhakan Kishan-Dhakan deleted the filter_getblobbers branch May 4, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants