Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenomics suite #2320

Merged
merged 7 commits into from May 6, 2023
Merged

Tokenomics suite #2320

merged 7 commits into from May 6, 2023

Conversation

Jayashsatolia403
Copy link
Collaborator

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

code/go/0chain.net/smartcontract/dbs/event/challenge.go Outdated Show resolved Hide resolved
code/go/0chain.net/smartcontract/storagesc/allocation.go Outdated Show resolved Hide resolved
code/go/0chain.net/smartcontract/storagesc/handler.go Outdated Show resolved Hide resolved
code/go/0chain.net/smartcontract/storagesc/handler.go Outdated Show resolved Hide resolved
code/go/0chain.net/smartcontract/storagesc/handler.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2023

Codecov Report

Merging #2320 (87fb5fa) into staging (32b075e) will decrease coverage by 0.12%.
The diff coverage is 8.88%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging    #2320      +/-   ##
===========================================
- Coverage    28.95%   28.83%   -0.12%     
===========================================
  Files          377      380       +3     
  Lines        63165    63465     +300     
===========================================
+ Hits         18290    18302      +12     
- Misses       42724    43007     +283     
- Partials      2151     2156       +5     
Flag Coverage Δ
Unit-Tests 28.83% <8.88%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...net/smartcontract/dbs/event/reward_delegate_dev.go 0.00% <0.00%> (ø)
...ain.net/smartcontract/dbs/event/reward_provider.go 0.00% <ø> (ø)
...net/smartcontract/dbs/event/reward_provider_dev.go 0.00% <0.00%> (ø)
...e/go/0chain.net/smartcontract/storagesc/handler.go 2.78% <0.00%> (-0.02%) ⬇️
...o/0chain.net/smartcontract/storagesc/reward_dev.go 0.00% <0.00%> (ø)
...go/0chain.net/smartcontract/dbs/event/challenge.go 43.33% <20.00%> (-3.10%) ⬇️
...ain.net/smartcontract/dbs/event/reward_delegate.go 54.00% <50.00%> (-0.17%) ⬇️
...go/0chain.net/smartcontract/stakepool/stakepool.go 19.34% <50.00%> (+0.04%) ⬆️
...chain.net/smartcontract/stakepool/edb_stakepool.go 74.41% <72.72%> (-1.34%) ⬇️
...go/0chain.net/smartcontract/storagesc/challenge.go 30.07% <80.00%> (+0.27%) ⬆️
... and 1 more

... and 2 files with indirect coverage changes

@Jayashsatolia403 Jayashsatolia403 linked an issue Apr 26, 2023 that may be closed by this pull request
2 tasks
@peterlimg
Copy link
Member

@Jayashsatolia403 please also do pagination for all the new endpoints

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit c5c503e into staging May 6, 2023
8 checks passed
@dabasov dabasov deleted the tokenomics_suite branch May 6, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Blobber rewards and service charges
4 participants