Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync dockerfile for integration testing #2347

Merged
merged 4 commits into from
May 23, 2023
Merged

Sync dockerfile for integration testing #2347

merged 4 commits into from
May 23, 2023

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Apr 28, 2023

Fixes

Changes

This PR refreshes dockerfile for conductor testing to standard dockerfile

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2023

Codecov Report

Merging #2347 (60e8f63) into staging (7b352d9) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           staging    #2347      +/-   ##
===========================================
+ Coverage    29.11%   29.13%   +0.02%     
===========================================
  Files          380      380              
  Lines        63295    63295              
===========================================
+ Hits         18426    18439      +13     
+ Misses       42713    42692      -21     
- Partials      2156     2164       +8     
Flag Coverage Δ
Unit-Tests 29.13% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterlimg
Copy link
Member

System tests failures are not related to the changes.

@peterlimg peterlimg merged commit c9372d8 into staging May 23, 2023
6 of 7 checks passed
@peterlimg peterlimg deleted the sync/dockerfile branch May 23, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants