Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metrics state and events computation times #2357

Merged
merged 6 commits into from May 5, 2023
Merged

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented May 2, 2023

Fixes

fixes part of #2196

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@Sriep Sriep changed the title New metrics state and events comutation times New metrics state and events computation times May 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #2357 (a3b7751) into staging (a772384) will increase coverage by 0.00%.
The diff coverage is 62.50%.

馃摚 This organization is not using Codecov鈥檚 GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           staging    #2357   +/-   ##
========================================
  Coverage    28.95%   28.95%           
========================================
  Files          377      377           
  Lines        63151    63165   +14     
========================================
+ Hits         18286    18291    +5     
- Misses       42713    42724   +11     
+ Partials      2152     2150    -2     
Flag Coverage 螖
Unit-Tests 28.95% <62.50%> (+<0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...de/go/0chain.net/chaincore/chain/protocol_block.go 0.00% <0.00%> (酶)
code/go/0chain.net/chaincore/chain/state.go 4.24% <33.33%> (+0.27%) 猬嗭笍
code/go/0chain.net/sharder/handler.go 44.08% <100.00%> (+1.88%) 猬嗭笍

... and 3 files with indirect coverage changes

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk staging
zboxcli staging
zwalletcli staging
0chain new_metrics
blobber staging
authorizer staging
0box staging
0dns staging

@dabasov dabasov merged commit 32b075e into staging May 5, 2023
7 of 8 checks passed
@dabasov dabasov deleted the new_metrics branch May 5, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants