Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save rewards only if miner exists in the network #2358

Merged
merged 1 commit into from May 3, 2023

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented May 2, 2023

Fixes

Screenshot from 2023-04-28 09-51-02

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

Codecov Report

Merging #2358 (d35cec9) into staging (afbbb96) will increase coverage by 0.00%.
The diff coverage is 33.33%.

馃摚 This organization is not using Codecov鈥檚 GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           staging    #2358   +/-   ##
========================================
  Coverage    28.97%   28.98%           
========================================
  Files          377      377           
  Lines        63034    63036    +2     
========================================
+ Hits         18267    18268    +1     
- Misses       42617    42619    +2     
+ Partials      2150     2149    -1     
Flag Coverage 螖
Unit-Tests 28.98% <33.33%> (+<0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
code/go/0chain.net/smartcontract/minersc/fees.go 30.71% <33.33%> (+0.33%) 猬嗭笍

... and 3 files with indirect coverage changes

@lpoli lpoli linked an issue May 3, 2023 that may be closed by this pull request
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit a2df263 into staging May 3, 2023
8 checks passed
@dabasov dabasov deleted the fix/pay-reward-issue branch May 3, 2023 12:34
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getRewardedMiner does not return error if the error was 'node not found', we should not continue to get random miner from minerList when it happens, as if other miners can get. the miner successfully, they will result in different MPT state due to the different miner they selected for rewarding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conductor Issue: Sending bad VRFS to everyone
4 participants