Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing sharder unit tests #236

Merged
merged 19 commits into from
Jun 2, 2021
Merged

Fixing sharder unit tests #236

merged 19 commits into from
Jun 2, 2021

Conversation

MurashovVen
Copy link
Contributor

  • Removing printing out.
  • Creating custom mocks.
  • Removing initializing process of sharder tests (should reduce the risks of race conditions and increase readability).
  • Code refactoring.

@MurashovVen MurashovVen linked an issue May 4, 2021 that may be closed by this pull request
Failing unit tests. #130
Closed
@platsko platsko requested review from platsko and Sriep May 4, 2021 13:15
@Sriep
Copy link
Contributor

Sriep commented May 5, 2021 •
edited

With this, can we close PR #72 Add unit tests to sharder?

@Sriep Sriep mentioned this pull request May 6, 2021
Closed
@Sriep
Copy link
Contributor

Sriep commented May 9, 2021 •
edited

Why is code/go/0chain.net/mocks/core/datastore/custom.go in the datastore package while code/go/0chain.net/mocks/sharder/blockstore/custom.go is in the mocks package? I would have expected consistent package naming here.

@MurashovVen MurashovVen mentioned this pull request May 11, 2021
Merged
@MurashovVen
Fixing race issues #2
19dcd0e
@MurashovVen
Merge remote-tracking branch 'origin/master' into fix/sharder_unit_tests
073e95a 
# Conflicts:
#	code/go/0chain.net/sharder/block_test.go
#	code/go/0chain.net/sharder/blockdb/blockdb_test.go
@MurashovVen
Fixing race issues #3
a3bc8c8
@MurashovVen
Add parallel running for tests:
1c6b734 
- TestNotarizedBlockHandler
- TestBlockSummaryRequestHandler
@MurashovVen
Fix lint issues
f986a43
@MurashovVen
Need fixing
0dc4618
@MurashovVen
Remove parallel running
4564046
@MurashovVen
Change package name
885bdf8
Sriep
Sriep suggested changes May 20, 2021
View reviewed changes
code/go/0chain.net/mocks/core/datastore/custom.go Outdated Show resolved Hide resolved
code/go/0chain.net/mocks/sharder/blockstore/custom.go Outdated Show resolved Hide resolved
code/go/0chain.net/mocks/core/datastore/custom.go Outdated Show resolved Hide resolved
Sriep added 5 commits June 1, 2021 18:37
@Sriep
Merge remote-tracking branch 'origin/master' into fix/sharder_unit_tests
3a5853b 
# Conflicts:
#	code/go/0chain.net/go.sum
#	code/go/0chain.net/sharder/blockstore/fs_store_test.go
#	code/go/0chain.net/sharder/sharder_init_test.go
@Sriep
Merge remote-tracking branch 'origin/master' into fix/sharder_unit_tests
bb78331
@Sriep
merge in master changes
82f445e
@Sriep
fix
5da9a9f
@Sriep
refactor
a5cb522
@Sriep Sriep merged commit d358ddd into master Jun 2, 2021
@Sriep Sriep deleted the fix/sharder_unit_tests branch June 2, 2021 10:41
@Sriep Sriep mentioned this pull request Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sriep Sriep Sriep requested changes

@platsko platsko Awaiting requested review from platsko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing unit tests.
2 participants
@MurashovVen @Sriep