Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/handle kill shutdown for aggregates and snapshots #2367

Merged

Conversation

devyetii
Copy link
Collaborator

@devyetii devyetii commented May 3, 2023

Fixes

Closes #2211
Closes #2359

Changes

  • Remove handling of provider deletion
  • Add handling of provider kill/shutdown
  • Fix unit tests

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@devyetii devyetii linked an issue May 3, 2023 that may be closed by this pull request
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fix unit tests

fix unit test

fix unit tests
@devyetii devyetii force-pushed the fix/handle-kill-shutdown-for-aggregates-and-snapshots branch from e48a60c to 5cccd81 Compare May 3, 2023 22:47
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2023

Codecov Report

Merging #2367 (b0de551) into staging (eba7595) will decrease coverage by 0.01%.
The diff coverage is 95.77%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging    #2367      +/-   ##
===========================================
- Coverage    28.98%   28.98%   -0.01%     
===========================================
  Files          377      377              
  Lines        63040    63039       -1     
===========================================
- Hits         18273    18269       -4     
- Misses       42617    42636      +19     
+ Partials      2150     2134      -16     
Flag Coverage Δ
Unit-Tests 28.98% <95.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n.net/smartcontract/dbs/event/blobber_aggregate.go 76.78% <85.71%> (+3.01%) ⬆️
...et/smartcontract/dbs/event/authorizer_aggregate.go 65.89% <100.00%> (+1.60%) ⬆️
...net/smartcontract/dbs/event/authorizer_snapshot.go 80.35% <100.00%> (+1.51%) ⬆️
...in.net/smartcontract/dbs/event/blobber_snapshot.go 94.00% <100.00%> (+0.52%) ⬆️
...ain.net/smartcontract/dbs/event/miner_aggregate.go 65.35% <100.00%> (+1.58%) ⬆️
...hain.net/smartcontract/dbs/event/miner_snapshot.go 79.62% <100.00%> (+1.62%) ⬆️
.../go/0chain.net/smartcontract/dbs/event/provider.go 64.70% <100.00%> (+0.70%) ⬆️
...n.net/smartcontract/dbs/event/sharder_aggregate.go 65.35% <100.00%> (+1.58%) ⬆️
...in.net/smartcontract/dbs/event/sharder_snapshot.go 79.62% <100.00%> (+1.62%) ⬆️
...net/smartcontract/dbs/event/validator_aggregate.go 64.51% <100.00%> (+1.55%) ⬆️
... and 1 more

... and 11 files with indirect coverage changes

fix sharder unit test

fix unit test

fix unit tests

fix unit test
@devyetii devyetii force-pushed the fix/handle-kill-shutdown-for-aggregates-and-snapshots branch from 5831a39 to b0de551 Compare May 4, 2023 23:51
@dabasov dabasov merged commit 28662fe into staging May 5, 2023
7 checks passed
@dabasov dabasov deleted the fix/handle-kill-shutdown-for-aggregates-and-snapshots branch May 5, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants