Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some Benchmark errors #2389

Merged
merged 26 commits into from
May 11, 2023
Merged

Fixes some Benchmark errors #2389

merged 26 commits into from
May 11, 2023

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented May 8, 2023

Fixes

Fixes the following failing benchmark tests.

  • storage.commit_connection
  • storage.blobber_block_rewards
  • storage.add_validator
  • storage.stake_pool_lock
  • storage.update_settings
  • zcnsc.add-authorizer
  • zcnsc.authorizer-health-check
  • zcnsc.update-global-config
  • storage.update_settings

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk staging
zboxcli staging
zwalletcli staging
0chain benchmark_fixes
blobber staging
authorizer staging
0box staging
0dns staging

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #2389 (3e43292) into staging (3c38dfd) will increase coverage by 0.33%.
The diff coverage is 21.15%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           staging    #2389      +/-   ##
===========================================
+ Coverage    28.81%   29.14%   +0.33%     
===========================================
  Files          380      380              
  Lines        63509    63512       +3     
===========================================
+ Hits         18300    18512     +212     
+ Misses       43063    42848     -215     
- Partials      2146     2152       +6     
Flag Coverage Δ
Unit-Tests 29.14% <21.15%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et/smartcontract/storagesc/benchmark_rest_tests.go 86.77% <ø> (+86.77%) ⬆️
...ain.net/smartcontract/storagesc/benchmark_setup.go 4.12% <5.26%> (-0.33%) ⬇️
...ain.net/smartcontract/storagesc/benchmark_tests.go 76.75% <50.00%> (+0.63%) ⬆️
.../0chain.net/smartcontract/zcnsc/benchmark_tests.go 73.68% <100.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 4fcd034 into staging May 11, 2023
5 of 7 checks passed
@dabasov dabasov deleted the benchmark_fixes branch May 11, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants