Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rewards endpoints #2440

Merged
merged 45 commits into from Jun 17, 2023
Merged

Fixed rewards endpoints #2440

merged 45 commits into from Jun 17, 2023

Conversation

Jayashsatolia403
Copy link
Collaborator

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Merging #2440 (e2a1087) into staging (1e180fd) will decrease coverage by 0.03%.
The diff coverage is 13.61%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           staging    #2440      +/-   ##
===========================================
- Coverage    28.80%   28.78%   -0.03%     
===========================================
  Files          380      380              
  Lines        63950    63988      +38     
===========================================
- Hits         18421    18418       -3     
- Misses       43359    43403      +44     
+ Partials      2170     2167       -3     
Flag Coverage Δ
Unit-Tests 28.78% <13.61%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...go/0chain.net/smartcontract/dbs/event/challenge.go 33.76% <0.00%> (-5.04%) ⬇️
...net/smartcontract/dbs/event/reward_delegate_dev.go 0.00% <ø> (ø)
...ain.net/smartcontract/dbs/event/reward_provider.go 0.00% <0.00%> (ø)
...net/smartcontract/dbs/event/reward_provider_dev.go 0.00% <0.00%> (ø)
...o/0chain.net/smartcontract/storagesc/reward_dev.go 0.00% <0.00%> (ø)
...ain.net/smartcontract/dbs/event/reward_delegate.go 58.18% <50.00%> (ø)
...go/0chain.net/smartcontract/storagesc/challenge.go 28.32% <83.33%> (-0.41%) ⬇️
...chain.net/smartcontract/stakepool/edb_stakepool.go 73.17% <87.50%> (-1.25%) ⬇️
...o/0chain.net/smartcontract/storagesc/allocation.go 50.87% <100.00%> (ø)
...chain.net/smartcontract/storagesc/challengepool.go 58.13% <100.00%> (ø)
... and 4 more

... and 2 files with indirect coverage changes

@Jayashsatolia403 Jayashsatolia403 changed the title WIP : Added new endpoint for the challenge rewards Added new endpoint for the challenge rewards May 25, 2023
@Jayashsatolia403 Jayashsatolia403 changed the title Added new endpoint for the challenge rewards Fixed rewards endpoint May 26, 2023
@Jayashsatolia403 Jayashsatolia403 changed the title Fixed rewards endpoint Fixed rewards endpoints May 26, 2023
code/go/0chain.net/smartcontract/dbs/types.go Outdated Show resolved Hide resolved
code/go/0chain.net/smartcontract/storagesc/handler.go Outdated Show resolved Hide resolved
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit c118797 into staging Jun 17, 2023
6 of 8 checks passed
@dabasov dabasov deleted the fix/challenges branch June 17, 2023 20:44
@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped false
system-tests master
gosdk staging
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer fix/conductor-tests
0box staging
0dns staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants