Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parrametrize generators to be a percentage #245

Merged
merged 4 commits into from
May 12, 2021
Merged

Parrametrize generators to be a percentage #245

merged 4 commits into from
May 12, 2021

Conversation

peterlimg
Copy link
Member

@peterlimg peterlimg commented May 6, 2021 •
edited

Fixes: #239

Parametrize the generators to be a percentage instead of a hard-coded number.

TODO:

  • Fix the rollback logging code, the conflict variable names and package names.

@guruhubb guruhubb requested a review from Sriep May 6, 2021 20:11
@guruhubb guruhubb requested review from bbist and platsko and removed request for bbist May 7, 2021 06:34
@platsko platsko self-requested a review May 12, 2021 13:22
@platsko platsko merged commit dbb7e41 into master May 12, 2021
@platsko platsko deleted the feature/percentage-generator branch May 12, 2021 15:55
@Sriep Sriep mentioned this pull request May 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platsko platsko platsko approved these changes

@Sriep Sriep Awaiting requested review from Sriep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generator parametrization
2 participants
@peterlimg @platsko