Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to return blobbers by ids #2458

Merged
merged 6 commits into from May 31, 2023

Conversation

manasnisar
Copy link
Contributor

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@manasnisar manasnisar changed the title Added support to return blobber by ids Added functionality to return blobbers by ids May 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2023

Codecov Report

Merging #2458 (67619fe) into staging (1ac8df7) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           staging    #2458      +/-   ##
===========================================
- Coverage    28.97%   28.94%   -0.03%     
===========================================
  Files          381      381              
  Lines        63824    63841      +17     
===========================================
- Hits         18493    18479      -14     
- Misses       43168    43204      +36     
+ Partials      2163     2158       -5     
Flag Coverage Δ
Unit-Tests 28.94% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/go/0chain.net/smartcontract/storagesc/handler.go 6.31% <0.00%> (-0.07%) ⬇️

... and 2 files with indirect coverage changes

@manasnisar manasnisar marked this pull request as ready for review May 29, 2023 07:29
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 9dc943b into staging May 31, 2023
5 of 8 checks passed
@dabasov dabasov deleted the anas/feat/blobbers-by-ids branch May 31, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants