Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This issue should have been fixed via #2462 actually, it happens in similar way that tests submit lock transactions with negative transaction value, while before #2462, we don't validate the value and will put it to txn pool. In the txn processing code, we ignored the token converting error and emit event to update the allocation.write_pool, which will be fixed by this PR. Anyway, because the #2462, the transactions with invalid value will be ignored, that's why we don't see this error recently.
Changes
Need to be mentioned in CHANGELOG.md?
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):