New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix challenge numbers for expired allocations #2501
Fix challenge numbers for expired allocations #2501
Conversation
…d_allocations' into fix/challenge_numbers_for_expired_allocations
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## staging #2501 +/- ##
===========================================
+ Coverage 28.81% 28.82% +0.01%
===========================================
Files 380 380
Lines 63924 63935 +11
===========================================
+ Hits 18420 18431 +11
+ Misses 43332 43325 -7
- Partials 2172 2179 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…d_allocations' into fix/challenge_numbers_for_expired_allocations
…d_allocations' into fix/challenge_numbers_for_expired_allocations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…ions # Conflicts: # code/go/0chain.net/smartcontract/storagesc/challenge.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes
Changes
Need to be mentioned in CHANGELOG.md?
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):