Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix challenge numbers for expired allocations #2501

Merged
merged 24 commits into from Jun 13, 2023

Conversation

Jayashsatolia403
Copy link
Collaborator

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Merging #2501 (9446a73) into staging (381429e) will increase coverage by 0.01%.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           staging    #2501      +/-   ##
===========================================
+ Coverage    28.81%   28.82%   +0.01%     
===========================================
  Files          380      380              
  Lines        63924    63935      +11     
===========================================
+ Hits         18420    18431      +11     
+ Misses       43332    43325       -7     
- Partials      2172     2179       +7     
Flag Coverage Δ
Unit-Tests 28.82% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/go/0chain.net/smartcontract/dbs/event/blobber.go 31.40% <0.00%> (-0.39%) ⬇️
...go/0chain.net/smartcontract/storagesc/challenge.go 28.72% <0.00%> (+0.15%) ⬆️
...o/0chain.net/smartcontract/storagesc/allocation.go 50.87% <75.00%> (+0.15%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dabasov dabasov merged commit c5c3d9a into staging Jun 13, 2023
8 checks passed
@dabasov dabasov deleted the fix/challenge_numbers_for_expired_allocations branch June 13, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants