Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/counter merge operator tests #2508

Merged
merged 3 commits into from Jun 13, 2023
Merged

Conversation

devyetii
Copy link
Collaborator

@devyetii devyetii commented Jun 9, 2023

Fixes

  • Fixing simple issue in counter merge operator
  • Adding unit tests to the merge operator

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023

Codecov Report

Merging #2508 (697348d) into staging (47efd9b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           staging    #2508      +/-   ##
===========================================
+ Coverage    28.78%   28.80%   +0.01%     
===========================================
  Files          380      380              
  Lines        63877    63877              
===========================================
+ Hits         18385    18397      +12     
+ Misses       43325    43311      -14     
- Partials      2167     2169       +2     
Flag Coverage Δ
Unit-Tests 28.80% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in.net/core/ememorystore/counter_merge_operator.go 50.00% <100.00%> (+50.00%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devyetii looks good to me, please also check the err here, we should not ignore the error.

@peterlimg
Copy link
Member

I'll merge and fix error checking here in a new PR.

@peterlimg peterlimg merged commit 381429e into staging Jun 13, 2023
8 checks passed
@peterlimg peterlimg deleted the feat/counter-merge-operator-tests branch June 13, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants