TestConcurrentCodec remove race errors #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platsko
suggested changes
May 8, 2021
platsko
approved these changes
May 8, 2021
platsko
reviewed
May 8, 2021
| wg.Done() | ||
| }() | ||
| }(i, &wg) |
There was a problem hiding this comment.
I can't figure out what is the reason for passing waitgroup to goroutine as an argument?
Isn't such need in this case. This will allocates memory on the heap (run to heap) and appends work for the garbage collector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestConcurrentCodecreworked to remove race errors. Aims to simulate the wayblock.Blockworks withToMsgpack.