Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use nonce for freeallocation #2542

Merged
merged 2 commits into from Jun 28, 2023
Merged

use nonce for freeallocation #2542

merged 2 commits into from Jun 28, 2023

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented Jun 19, 2023

Fixes

#2529
#2525
#2523

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #2542 (9217a8e) into staging (3c50817) will increase coverage by 0.00%.
The diff coverage is 66.03%.

❗ Current head 9217a8e differs from pull request most recent head 861ed7f. Consider uploading reports for the commit 861ed7f to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##           staging    #2542   +/-   ##
========================================
  Coverage    28.76%   28.77%           
========================================
  Files          380      380           
  Lines        64064    64049   -15     
========================================
+ Hits         18430    18431    +1     
+ Misses       43452    43437   -15     
+ Partials      2182     2181    -1     
Flag Coverage Δ
Unit-Tests 28.77% <66.03%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain.net/smartcontract/storagesc/benchmark_setup.go 3.96% <0.00%> (ø)
...net/smartcontract/storagesc/free_allocation_gen.go 22.36% <45.00%> (+<0.01%) ⬆️
...ain.net/smartcontract/storagesc/free_allocation.go 38.00% <85.71%> (-0.79%) ⬇️
...o/0chain.net/smartcontract/storagesc/allocation.go 51.06% <100.00%> (+0.27%) ⬆️
...et/smartcontract/storagesc/benchmark_rest_tests.go 86.77% <100.00%> (ø)
...ain.net/smartcontract/storagesc/benchmark_tests.go 74.65% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped false
system-tests free-storage
gosdk staging
zboxcli staging
zwalletcli staging
0chain freestorage
blobber staging
authorizer staging
0box staging
0dns staging

@Kishan-Dhakan Kishan-Dhakan changed the base branch from staging to sprint-june-5 June 28, 2023 15:11
@Kishan-Dhakan
Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan merged commit ab6bc04 into sprint-june-5 Jun 28, 2023
3 checks passed
@Kishan-Dhakan Kishan-Dhakan deleted the freestorage branch June 28, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants