Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repeated validation of transaction #2552

Merged
merged 3 commits into from Jul 5, 2023

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Jun 24, 2023

Fixes

Transaction validation is done twice which is redundant.

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2023

Codecov Report

Merging #2552 (8197a7b) into sprint-july-1 (5bb157f) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@              Coverage Diff               @@
##           sprint-july-1    #2552   +/-   ##
==============================================
  Coverage          28.79%   28.79%           
==============================================
  Files                380      380           
  Lines              64106    64101    -5     
==============================================
+ Hits               18458    18461    +3     
+ Misses             43467    43456   -11     
- Partials            2181     2184    +3     
Flag Coverage Δ
Unit-Tests 28.79% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ode/go/0chain.net/chaincore/transaction/handler.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@Kishan-Dhakan Kishan-Dhakan changed the base branch from staging to sprint-july-1 July 5, 2023 20:26
@Kishan-Dhakan
Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan merged commit d583b0b into sprint-july-1 Jul 5, 2023
5 of 8 checks passed
@Kishan-Dhakan Kishan-Dhakan deleted the remove/double-validation branch July 5, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants