New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore Expiration field during create_new_allocation #2553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
# Conflicts: # code/go/0chain.net/smartcontract/storagesc/allocation_test.go
Manual system tests [failure] with the following config
|
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## sprint-june-5 #2553 +/- ##
================================================
Coverage ? 28.77%
================================================
Files ? 380
Lines ? 64037
Branches ? 0
================================================
Hits ? 18428
Misses ? 43426
Partials ? 2183
Flags with carried forward coverage won't be shown. Click here to find out more. |
Manual system tests [cancelled] with the following config
|
Manual system tests [success] with the following config
|
Fixes
#2531
Changes
Ignoring the Expiration value provided in the request during create_new_allocation and hardcoding it with the TimeUnit value from the configuations.
Need to be mentioned in CHANGELOG.md?
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):