Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Expiration field during create_new_allocation #2553

Merged
merged 13 commits into from Jun 29, 2023

Conversation

sunilmhta
Copy link
Contributor

Fixes

#2531

Changes

Ignoring the Expiration value provided in the request during create_new_allocation and hardcoding it with the TimeUnit value from the configuations.

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@sunilmhta sunilmhta linked an issue Jun 25, 2023 that may be closed by this pull request
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sunilmhta sunilmhta changed the base branch from staging to sprint-june-5 June 27, 2023 18:08
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests sprint-june-5
gosdk staging
zboxcli staging
zwalletcli staging
0chain users/sunilmhta/fix/2531
blobber staging
authorizer staging
0box staging
0dns staging

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (sprint-june-5@ab6bc04). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff                @@
##             sprint-june-5    #2553   +/-   ##
================================================
  Coverage                 ?   28.77%           
================================================
  Files                    ?      380           
  Lines                    ?    64037           
  Branches                 ?        0           
================================================
  Hits                     ?    18428           
  Misses                   ?    43426           
  Partials                 ?     2183           
Flag Coverage Δ
Unit-Tests 28.77% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped false
system-tests sprint-june-5
gosdk staging
zboxcli staging
zwalletcli staging
0chain users/sunilmhta/fix/2531
blobber staging
authorizer staging
0box staging
0dns staging

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped false
system-tests sprint-june-5
gosdk staging
zboxcli staging
zwalletcli staging
0chain users/sunilmhta/fix/2531
blobber staging
authorizer staging
0box staging
0dns staging

@Kishan-Dhakan Kishan-Dhakan merged commit 193a580 into sprint-june-5 Jun 29, 2023
7 of 10 checks passed
@Kishan-Dhakan Kishan-Dhakan deleted the users/sunilmhta/fix/2531 branch June 29, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcode allocation duration to a time_unit
6 participants