Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block rewards endpoint #2574

Merged
merged 12 commits into from Jul 6, 2023
Merged

Conversation

Jayashsatolia403
Copy link
Collaborator

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2023

Codecov Report

Merging #2574 (97bb840) into sprint-july-1 (d583b0b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 97bb840 differs from pull request most recent head d9ea957. Consider uploading reports for the commit d9ea957 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                Coverage Diff                @@
##           sprint-july-1    #2574      +/-   ##
=================================================
- Coverage          28.79%   28.79%   -0.01%     
=================================================
  Files                380      380              
  Lines              64101    64091      -10     
=================================================
- Hits               18461    18458       -3     
+ Misses             43460    43454       -6     
+ Partials            2180     2179       -1     
Flag Coverage Δ
Unit-Tests 28.79% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...go/0chain.net/smartcontract/dbs/event/challenge.go 28.88% <0.00%> (-4.88%) ⬇️
...net/smartcontract/dbs/event/reward_provider_dev.go 0.00% <0.00%> (ø)
...o/0chain.net/smartcontract/storagesc/allocation.go 50.99% <0.00%> (-0.17%) ⬇️

... and 6 files with indirect coverage changes

@Jayashsatolia403 Jayashsatolia403 changed the base branch from staging to sprint-july-1 July 6, 2023 11:34
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 5a0b496 into sprint-july-1 Jul 6, 2023
7 checks passed
@dabasov dabasov deleted the fix/block-rewards-endpoint branch July 6, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants