Using Data Transfer Objects in Update Provider SmartContract Calls

[sunilmhta]

Fixes

#2544

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

• Ensure system tests are passing. If not Run them manually to check for any regressions 📋
• Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
• Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

• blobber:
• gosdk: Change the contract of Sharder and Miner update settings gosdk#1085
• system_test:
• zboxcli:
• zwalletcli: Change the Update provider settings call as per the new model in gosdk zwalletcli#274
• Other: ...

[codecov-commenter]

Codecov Report

Merging #2577 (8281b18) into sprint-july-1 (6e62af0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                Coverage Diff                @@
##           sprint-july-1    #2577      +/-   ##
=================================================
- Coverage          28.80%   28.80%   -0.01%     
=================================================
  Files                380      380              
  Lines              64073    64103      +30     
=================================================
+ Hits               18459    18467       +8     
- Misses             43433    43451      +18     
- Partials            2181     2185       +4     

Flag	Coverage Δ
Unit-Tests	28.80% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
code/go/0chain.net/smartcontract/minersc/miner.go	18.86% <0.00%> (-2.01%)	⬇️
...ode/go/0chain.net/smartcontract/minersc/sharder.go	20.73% <0.00%> (-0.30%)	⬇️
...de/go/0chain.net/smartcontract/storagesc/config.go	7.07% <0.00%> (ø)

... and 4 files with indirect coverage changes

[dabasov]

lgtm

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	false
system-tests	master
gosdk	staging
zboxcli	staging
zwalletcli	staging
0chain	users/sunilmhta/fix/2544/0chain/usingmap
blobber	staging
authorizer	staging
0box	staging
0dns	staging

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	false
system-tests	master
gosdk	users/sunilmhta/fix/2544/gosdk-sharder-miner
zboxcli	sprint-july-1
zwalletcli	users/sunilmhta/fix/2544/zwallet-sharder-miner
0chain	users/sunilmhta/fix/2544/0chain/usingmap
blobber	sprint-july-1
authorizer	sprint-july-1
0box	sprint-july-1
0dns	staging

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	false
system-tests	master
gosdk	users/sunilmhta/fix/2544/gosdk-sharder-miner
zboxcli	sprint-july-1
zwalletcli	users/sunilmhta/fix/2544/zwallet-sharder-miner
0chain	users/sunilmhta/fix/2544/0chain/usingmap
blobber	staging
authorizer	staging
0box	staging
0dns	staging

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	false
system-tests	sprint-july-1
gosdk	users/sunilmhta/fix/2544/gosdk-sharder-miner
zboxcli	sprint-july-1
zwalletcli	users/sunilmhta/fix/2544/zwallet-sharder-miner
0chain	users/sunilmhta/fix/2544/0chain/usingmap
blobber	staging
authorizer	staging
0box	staging
0dns	staging

[service-0chain]

Manual system tests [cancelled] with the following config

config	value
tests skipped	false
system-tests	master
gosdk	users/sunilmhta/fix/2544/gosdk-sharder-miner
zboxcli	staging
zwalletcli	users/sunilmhta/fix/2544/zwallet-sharder-miner
0chain	users/sunilmhta/fix/2544/0chain/usingmap
blobber	staging
authorizer	staging
0box	staging
0dns	staging

[service-0chain]

Manual system tests [cancelled] with the following config

config	value
tests skipped	false
system-tests	sprint-july-1
gosdk	users/sunilmhta/fix/2544/gosdk-sharder-miner
zboxcli	staging
zwalletcli	users/sunilmhta/fix/2544/zwallet-sharder-miner
0chain	users/sunilmhta/fix/2544/0chain/usingmap
blobber	staging
authorizer	staging
0box	staging
0dns	staging

[service-0chain]

Manual system tests [success] with the following config

config	value
tests skipped	false
system-tests	sprint-july-1
gosdk	users/sunilmhta/fix/2544/gosdk-sharder-miner
zboxcli	sprint-july-1
zwalletcli	users/sunilmhta/fix/2544/zwallet-sharder-miner
0chain	users/sunilmhta/fix/2544/0chain/usingmap
blobber	staging
authorizer	staging
0box	staging
0dns	staging

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	false
system-tests	sprint-july-1
gosdk	sprint-july-1
zboxcli	fix/fileMetaHash
zwalletcli	sprint-july-1
0chain	sprint-july-1
blobber	sprint-july-1
authorizer	staging
0box	staging
0dns	staging