Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do unexpected mints checking in benchmark tests #2603

Merged
merged 13 commits into from Jul 13, 2023
Merged

Conversation

peterlimg
Copy link
Member

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2023

Codecov Report

Merging #2603 (bb2b616) into sprint-july-1 (33f2cc5) will increase coverage by 0.00%.
The diff coverage is 16.98%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@              Coverage Diff               @@
##           sprint-july-1    #2603   +/-   ##
==============================================
  Coverage          28.81%   28.81%           
==============================================
  Files                380      380           
  Lines              64073    64127   +54     
==============================================
+ Hits               18465    18481   +16     
- Misses             43427    43458   +31     
- Partials            2181     2188    +7     
Flag Coverage Δ
Unit-Tests 28.81% <16.98%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
code/go/0chain.net/chaincore/chain/state.go 4.00% <0.00%> (-0.02%) ⬇️
.../0chain.net/chaincore/chain/state/state_context.go 18.32% <0.00%> (-0.35%) ⬇️
code/go/0chain.net/chaincore/transaction/entity.go 0.00% <0.00%> (ø)
...ode/go/0chain.net/chaincore/transaction/handler.go 0.00% <0.00%> (ø)
...go/0chain.net/smartcontract/dbs/event/challenge.go 33.76% <0.00%> (ø)
...ode/go/0chain.net/smartcontract/dbs/event/miner.go 24.74% <ø> (ø)
...net/smartcontract/dbs/event/reward_provider_dev.go 0.00% <0.00%> (ø)
...e/go/0chain.net/smartcontract/dbs/event/sharder.go 24.26% <ø> (ø)
.../0chain.net/smartcontract/dbs/event/writemarker.go 1.86% <ø> (ø)
...chain.net/smartcontract/minersc/benchmark_tests.go 70.00% <ø> (ø)
... and 11 more

... and 2 files with indirect coverage changes

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped false
system-tests 1033-fix-list
gosdk fix/get-list-from-blobbers
zboxcli display-correct-sizes
zwalletcli sprint-july-1
0chain sprint-july-1
blobber sprint-july-1
authorizer staging
0box staging
0dns staging

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests sprint-july-1
gosdk sprint-july-1
zboxcli sprint-july-1
zwalletcli sprint-july-1
0chain sprint-july-1
blobber sprint-july-1
authorizer staging
0box staging
0dns staging

@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped false
system-tests sprint-july-1
gosdk free-reads
zboxcli sprint-july-1
zwalletcli sprint-july-1
0chain sprint-july-1
blobber free-reads
authorizer staging
0box staging
0dns staging

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests sprint-july-1
gosdk free-reads
zboxcli sprint-july-1
zwalletcli sprint-july-1
0chain sprint-july-1
blobber free-reads
authorizer staging
0box staging
0dns staging

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests sprint-july-1
gosdk NOT OVERRIDDEN
zboxcli sprint-july-1
zwalletcli sprint-july-1
0chain sprint-july-1
blobber fix/open-challenge
authorizer
0box sprint-july-1
0dns staging

@peterlimg
Copy link
Member Author

@stewartie4 stewartie4 changed the base branch from sprint-july-1 to sprint-july-2 July 10, 2023 01:36
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped
system-tests sprint-july-1
gosdk sprint-july-1
zboxcli sprint-july-1
zwalletcli sprint-july-1
0chain sprint-july-1
blobber sprint-july-1
authorizer staging
0box staging
0dns

@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped false
system-tests sprint-july-1
gosdk sprint-july-1
zboxcli sprint-july-1
zwalletcli sprint-july-1
0chain sprint-july-1
blobber sprint-july-1
authorizer staging
0box staging
0dns

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain sprint-july-2
blobber
authorizer
0box
0dns

@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain sprint-july-2
blobber
authorizer
0box
0dns

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain bm-mints-check
blobber
authorizer
0box
0dns

@dabasov dabasov merged commit 01eb911 into sprint-july-2 Jul 13, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants