Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint for get min lock for updating allocation #2612

Merged
merged 22 commits into from Jul 19, 2023

Conversation

peterlimg
Copy link
Member

@peterlimg peterlimg commented Jul 11, 2023

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

* sprint-july-2: (58 commits)
  Add check before converting int64 go uint64
  unit test debug code
  Refactoring the big name funcs to shorter names.
  remove logging
  balance
  readpool lock
  error message
  unit test
  benchmark
  readpool unit test
  readpool
  readpool sc
  adding readpool
  Fix unit tests
  remove go:generate for the dto nodes.
  remove go:generate for the dto nodes.
  modifying blobber and validator update by sending merged blobber and validator to the updater
  testing
  pull build base & run base separately
  fix
  ...
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain sprint-july-2
blobber
authorizer
0box
0dns

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain feat/alloc-update-min-lock
blobber
authorizer
0box
0dns

@dabasov dabasov linked an issue Jul 17, 2023 that may be closed by this pull request
@dabasov dabasov changed the base branch from sprint-july-2 to sprint-july-3 July 17, 2023 10:15
@peterlimg peterlimg force-pushed the feat/alloc-update-min-lock branch 2 times, most recently from 9d9bc40 to 9186290 Compare July 18, 2023 09:56
* sprint-july-3: (50 commits)
  add bypass mint check
  Fix
  Fix
  Fix unit tests
  Fix unit tests
  Cleanup
  Emit update event for used field for blobbers when allocation is canc… (#2626)
  Fix
  Fix
  Fix
  Fix
  Fix
  Fix
  Cleanup
  Fix
  Debug unit tests
  Debug unit tests
  Debug logs
  Fix unit tests
  Updated with sprint-july-2
  ...
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (sprint-july-3@a0e113c). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff                @@
##             sprint-july-3    #2612   +/-   ##
================================================
  Coverage                 ?   28.79%           
================================================
  Files                    ?      383           
  Lines                    ?    64552           
  Branches                 ?        0           
================================================
  Hits                     ?    18590           
  Misses                   ?    43767           
  Partials                 ?     2195           
Flag Coverage Δ
Unit-Tests 28.79% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@peterlimg peterlimg requested a review from dabasov July 19, 2023 05:44
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit d10be1a into sprint-july-3 Jul 19, 2023
5 of 8 checks passed
@dabasov dabasov deleted the feat/alloc-update-min-lock branch July 19, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allocation min lock demand is not saved to event db
4 participants